Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies the count_ones definition. #1742

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Simplifies the count_ones definition. #1742

merged 1 commit into from
Dec 26, 2022

Conversation

fulmicoton
Copy link
Collaborator

@fulmicoton fulmicoton commented Dec 26, 2022

BEFORE

test null_index::dense::bench::bench_translate_codec_to_orig_1percent_filled_0comma005percent_hit   ... bench:         108 ns/iter (+/- 0)
test null_index::dense::bench::bench_translate_codec_to_orig_1percent_filled_10percent_hit          ... bench:      40,972 ns/iter (+/- 1,481)
test null_index::dense::bench::bench_translate_codec_to_orig_1percent_filled_full_scan              ... bench:     295,988 ns/iter (+/- 4,140)
test null_index::dense::bench::bench_translate_codec_to_orig_90percent_filled_0comma005percent_hit  ... bench:      13,406 ns/iter (+/- 221)
test null_index::dense::bench::bench_translate_codec_to_orig_90percent_filled_full_scan             ... bench:  14,705,793 ns/iter (+/- 387,693)
test null_index::dense::bench::bench_translate_orig_to_codec_10percent_filled_1percent_hit          ... bench:     151,846 ns/iter (+/- 2,938)
test null_index::dense::bench::bench_translate_orig_to_codec_1percent_filled_10percent_hit          ... bench:     151,359 ns/iter (+/- 1,497)
test null_index::dense::bench::bench_translate_orig_to_codec_50percent_filled_1percent_hit          ... bench:     151,540 ns/iter (+/- 1,414)
test null_index::dense::bench::bench_translate_orig_to_codec_5percent_filled_10percent_hit          ... bench:     152,820 ns/iter (+/- 2,893)
test null_index::dense::bench::bench_translate_orig_to_codec_5percent_filled_1percent_hit           ... bench:       9,307 ns/iter (+/- 148)
test null_index::dense::bench::bench_translate_orig_to_codec_90percent_filled_1percent_hit          ... bench:     153,765 ns/iter (+/- 2,122)
test null_index::dense::bench::bench_translate_orig_to_codec_full_scan_10percent_filled             ... bench:   3,076,425 ns/iter (+/- 206,460)
test null_index::dense::bench::bench_translate_orig_to_codec_full_scan_1percent_filled              ... bench:   3,060,372 ns/iter (+/- 146,893)
test null_index::dense::bench::bench_translate_orig_to_codec_full_scan_90percent_filled             ... bench:   2,958,577 ns/iter (+/- 110,274)

AFTER

test null_index::dense::bench::bench_translate_codec_to_orig_1percent_filled_0comma005percent_hit   ... bench:         108 ns/iter (+/- 3)
test null_index::dense::bench::bench_translate_codec_to_orig_1percent_filled_10percent_hit          ... bench:      39,525 ns/iter (+/- 1,162)
test null_index::dense::bench::bench_translate_codec_to_orig_1percent_filled_full_scan              ... bench:     292,545 ns/iter (+/- 3,883)
test null_index::dense::bench::bench_translate_codec_to_orig_90percent_filled_0comma005percent_hit  ... bench:      13,389 ns/iter (+/- 316)
test null_index::dense::bench::bench_translate_codec_to_orig_90percent_filled_full_scan             ... bench:  14,979,334 ns/iter (+/- 394,784)
test null_index::dense::bench::bench_translate_orig_to_codec_10percent_filled_1percent_hit          ... bench:     136,520 ns/iter (+/- 6,735)
test null_index::dense::bench::bench_translate_orig_to_codec_1percent_filled_10percent_hit          ... bench:     125,931 ns/iter (+/- 2,445)
test null_index::dense::bench::bench_translate_orig_to_codec_50percent_filled_1percent_hit          ... bench:     177,007 ns/iter (+/- 8,229)
test null_index::dense::bench::bench_translate_orig_to_codec_5percent_filled_10percent_hit          ... bench:     135,014 ns/iter (+/- 7,003)
test null_index::dense::bench::bench_translate_orig_to_codec_5percent_filled_1percent_hit           ... bench:       6,821 ns/iter (+/- 145)
test null_index::dense::bench::bench_translate_orig_to_codec_90percent_filled_1percent_hit          ... bench:     158,235 ns/iter (+/- 2,165)
test null_index::dense::bench::bench_translate_orig_to_codec_full_scan_10percent_filled             ... bench:   1,920,218 ns/iter (+/- 22,984)
test null_index::dense::bench::bench_translate_orig_to_codec_full_scan_1percent_filled              ... bench:   1,254,135 ns/iter (+/- 93,152)
test null_index::dense::bench::bench_translate_orig_to_codec_full_scan_90percent_filled             ... bench:   3,128,615 ns/iter (+/- 96,084)

@codecov-commenter
Copy link

Codecov Report

Merging #1742 (2f49a87) into main (45156fd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   94.13%   94.13%   -0.01%     
==========================================
  Files         267      267              
  Lines       50903    50900       -3     
==========================================
- Hits        47920    47913       -7     
- Misses       2983     2987       +4     
Impacted Files Coverage Δ
fastfield_codecs/src/null_index/dense.rs 99.16% <100.00%> (-0.01%) ⬇️
src/fieldnorm/writer.rs 96.96% <0.00%> (-1.52%) ⬇️
src/fastfield/multivalued/mod.rs 97.29% <0.00%> (-1.16%) ⬇️
fastfield_codecs/src/null_index/sparse.rs 95.27% <0.00%> (-0.19%) ⬇️
stacker/src/expull.rs 98.88% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton fulmicoton merged commit 9948a84 into main Dec 26, 2022
@fulmicoton fulmicoton deleted the simpler-count-ones branch December 26, 2022 07:08
This was referenced Jan 13, 2023
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants