-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor multivalue fastfield, refactor range query #1749
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 94.13% 94.14% +0.01%
==========================================
Files 267 268 +1
Lines 50900 50856 -44
==========================================
- Hits 47914 47878 -36
+ Misses 2986 2978 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
fn size_hint(&self) -> u32 { | ||
0 // heuristic possible by checking number of hits when fetching a block | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add unit tests on this module? I think there are a lot of tricky logic in this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests in range_query_ip_fastfield.rs
. I will add another PR that enables range queries on fastfield for all types. I'll try to cover all branches with tests there
Introduce MakeZero trait, remove make_zero from FastValue Merge two multivalue fastfield implementations into one prepare range query on fastfield for different types
1ccfba9
to
42c0472
Compare
Introduce MakeZero trait, remove make_zero from FastValue Merge two multivalue fastfield implementations into one prepare range query on fastfield for different types
Introduce MakeZero trait, remove make_zero from FastValue
Merge two multivalue fastfield implementations into one
prepare range query on fastfield for different types