refactor multivalue fastfield, refactor range query #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 94.13% 94.14% +0.01%
==========================================
Files 267 268 +1
Lines 50900 50856 -44
==========================================
- Hits 47914 47878 -36
+ Misses 2986 2978 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Jan 4, 2023
fulmicoton
reviewed
Jan 4, 2023
|
|
||
| fn size_hint(&self) -> u32 { | ||
| 0 // heuristic possible by checking number of hits when fetching a block | ||
| } |
There was a problem hiding this comment.
can you add unit tests on this module? I think there are a lot of tricky logic in this
There was a problem hiding this comment.
There are tests in range_query_ip_fastfield.rs. I will add another PR that enables range queries on fastfield for all types. I'll try to cover all branches with tests there
fulmicoton
approved these changes
Jan 4, 2023
Introduce MakeZero trait, remove make_zero from FastValue Merge two multivalue fastfield implementations into one prepare range query on fastfield for different types
PSeitz
force-pushed
the
fastfield_range_query
branch
from
1ccfba9
to
42c0472
Compare
This was referenced Jan 13, 2023
Closed
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
Introduce MakeZero trait, remove make_zero from FastValue Merge two multivalue fastfield implementations into one prepare range query on fastfield for different types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce MakeZero trait, remove make_zero from FastValue
Merge two multivalue fastfield implementations into one
prepare range query on fastfield for different types