Enable usage of FuzzyTermQuery for specific fields via QueryParser #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1750 +/- ##
=======================================
Coverage 94.13% 94.14%
=======================================
Files 267 267
Lines 50900 50966 +66
=======================================
+ Hits 47917 47984 +67
+ Misses 2983 2982 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PSeitz
reviewed
Jan 2, 2023
…les are not exposed to DoS attacks.
fulmicoton
approved these changes
Jan 4, 2023
|
Thank you @adamreichold |
This was referenced Jan 13, 2023
Closed
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
…uickwit-oss#1750) * Make nightly Clippy mostly happy. * Document how to produce TermSetQuery queries using QueryParser. * Enable construction of queries using FuzzyTermQuery via the QueryParser * Use FxHashMap instead of HashMap in the QueryParser as these hash tables are not exposed to DoS attacks. * Use a struct instead of a tuple to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the lead of
QueryParser::set_field_boost, this addsQueryParser::set_field_fuzzywhich sets whether literals will be matched against the given field usingFuzzyTermQueryinstead ofTermQueryusing the given parametersprefix,distanceandtransposition_cost_one.My personal use case for this is a single category-like
STRINGfield which I would like to include in default set but as I expect users to make spelling mistakes or use prefixes instead of the full categories.