Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cosmetic fixes for upcoming Clippy lints. #1771

Merged
merged 1 commit into from
Jan 10, 2023
Merged

More cosmetic fixes for upcoming Clippy lints. #1771

merged 1 commit into from
Jan 10, 2023

Conversation

adamreichold
Copy link
Collaborator

There are still some missing docs in the fastfield_codecs crate and Clippy will go nuts about uninlined-format-args if that ever reaches a stable version, but this should already make for a smaller diff before the next Clippy release.

@codecov-commenter
Copy link

Codecov Report

Merging #1771 (e6e7b5f) into main (7a8fce0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   94.12%   94.11%   -0.01%     
==========================================
  Files         282      282              
  Lines       52908    52873      -35     
==========================================
- Hits        49798    49763      -35     
  Misses       3110     3110              
Impacted Files Coverage Δ
src/lib.rs 96.04% <ø> (ø)
src/aggregation/mod.rs 98.84% <100.00%> (-0.04%) ⬇️
src/fastfield/alive_bitset.rs 99.31% <100.00%> (ø)
src/fastfield/multivalued/mod.rs 98.45% <100.00%> (ø)
src/postings/mod.rs 98.57% <100.00%> (ø)
src/query/range_query/range_query_ip_fastfield.rs 97.00% <100.00%> (-0.01%) ⬇️
src/query/range_query/range_query_u64_fastfield.rs 96.56% <100.00%> (-0.01%) ⬇️
sstable/src/block_reader.rs 73.77% <0.00%> (-1.64%) ⬇️
fastfield_codecs/src/null_index/sparse.rs 95.46% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit 8312c88 into quickwit-oss:main Jan 10, 2023
@adamreichold adamreichold deleted the clippy-from-the-future branch January 10, 2023 12:19
This was referenced Jan 13, 2023
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants