-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic column trait #1782
Merged
Merged
Generic column trait #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fulmicoton
commented
Jan 12, 2023
•
edited
Loading
edited
fulmicoton
force-pushed
the
generic-column-trait
branch
3 times, most recently
from
January 12, 2023 07:11
44d010c
to
b25128c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1782 +/- ##
==========================================
+ Coverage 94.12% 94.18% +0.06%
==========================================
Files 282 271 -11
Lines 52908 51720 -1188
==========================================
- Hits 49798 48713 -1085
+ Misses 3110 3007 -103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PSeitz
reviewed
Jan 12, 2023
fulmicoton
force-pushed
the
generic-column-trait
branch
9 times, most recently
from
January 16, 2023 06:02
434b49e
to
21fbc0e
Compare
Introduced asymetric OptionalCodec / SerializableOptionalCodec Removed cardinality from the columnar sstable. Added DynamicColumn Reorganized all files Change DenseCodec serialization logic. Renamed methods to rank/select Moved versioning footer to the columnar level
fulmicoton
force-pushed
the
generic-column-trait
branch
from
January 16, 2023 07:13
f249c96
to
681d68a
Compare
fulmicoton
added a commit
that referenced
this pull request
Jan 16, 2023
Introduced asymetric OptionalCodec / SerializableOptionalCodec Removed cardinality from the columnar sstable. Added DynamicColumn Reorganized all files Change DenseCodec serialization logic. Renamed methods to rank/select Moved versioning footer to the columnar level
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
Introduced asymetric OptionalCodec / SerializableOptionalCodec Removed cardinality from the columnar sstable. Added DynamicColumn Reorganized all files Change DenseCodec serialization logic. Renamed methods to rank/select Moved versioning footer to the columnar level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.