reuse stats for average #1785
Merged
reuse stats for average #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1785 +/- ##
=======================================
Coverage 94.11% 94.12%
=======================================
Files 282 282
Lines 53113 53079 -34
=======================================
- Hits 49986 49959 -27
+ Misses 3127 3120 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/aggregation/metric/average.rs
Outdated
| /// Contains mergeable version of average data. | ||
| #[derive(Default, Clone, Debug, PartialEq, Serialize, Deserialize)] | ||
| pub struct IntermediateAverage { | ||
| pub(crate) sum: f64, | ||
| pub(crate) doc_count: u64, | ||
| pub(crate) doc_count: u32, |
There was a problem hiding this comment.
Is there any inherent limit so that this is limited to 2^32 documents?
There was a problem hiding this comment.
Actually that change is incorrect, it's only valid on a segment level
fulmicoton
approved these changes
Jan 13, 2023
fulmicoton
pushed a commit
that referenced
this pull request
Jan 16, 2023
* reuse stats for average * fix count type
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
* reuse stats for average * fix count type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.