Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proximity search #1934 #2000

Closed
wants to merge 2 commits into from
Closed

fix proximity search #1934 #2000

wants to merge 2 commits into from

Commits on Apr 17, 2023

  1. change fn intersection_with_slop to store the matching entries from 

     the left array into the left array instead of storing the matching entries
 from the right array. Also, do not skip possible matches within the slop window.
 This makes the property (A intersect B) intersect C = (A intersect C) intersect B
 hold when used with a slop, which makes reasoning about correctness
 straight forward.
    @sftse
    sftse committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9368d57 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. fix race condition by making sure sorting is done before the segments… 

    … are passed

 on to the Intersection struct.
    @sftse
    sftse committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d41b384 View commit details
    Browse the repository at this point in the history