-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not reset pto_count on Initial ACKs #3551
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3dc10be
Do not reset pto_count on Initial ACKs
ianswett 2c682ab
Update draft-ietf-quic-recovery.md
ianswett f31ae49
Revert reflow changes to keep them separate
ianswett c682269
Update draft-ietf-quic-recovery.md
ianswett 50e0259
Set pto_count to 0 when dropping keys
ianswett 85bb93e
Only do this for the client
ianswett 96d2a6b
Update draft-ietf-quic-recovery.md
ianswett 62544e2
Apply suggestions from code review
ianswett 4b27838
Update draft-ietf-quic-recovery.md
ianswett 5a7994c
Merge branch 'master' into ianswett-initial-pto
ianswett 3bd99fb
Kazuho's suggestion
ianswett a1eff95
Apply suggestions from code review
ianswett 53b4584
Update draft-ietf-quic-recovery.md
ianswett 5226e28
Update draft-ietf-quic-recovery.md
ianswett e701772
Update draft-ietf-quic-recovery.md
ianswett e192b69
Update draft-ietf-quic-recovery.md
ianswett 02069cd
Update draft-ietf-quic-recovery.md
ianswett 1a1e49b
Update draft-ietf-quic-recovery.md
ianswett 7826ec1
Update draft-ietf-quic-recovery.md
ianswett 2687b58
Update draft-ietf-quic-recovery.md
ianswett beca7cd
Update draft-ietf-quic-recovery.md
ianswett 1f178bd
Update draft-ietf-quic-recovery.md
ianswett eb93527
Update draft-ietf-quic-recovery.md
ianswett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be done only when pto_count is set to 0? Why restart the timer here if the pto_count hasn't changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new RTT measurement is available, so the alarm value should always be updated.