-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use #
for comments and ;
as delimiter for single line expressions
#56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for your contribution to ETK. It's very much appreciated!
There are two doctests in the book that are failing (and unfortunately the CI isn't set up to run correctly on PRs.)
In doc/src/ch02-lang/README.md
there's an old-style comment left over, and in doc/src/ch02-lang/ch02-labels.md
there's a slightly different error.
You can run the book tests locally with the following, from the repository root:
mdbook test doc -L ./target/debug/deps
Looks like the error in |
The other test passes now though :D |
Rusty! The issue with the mdbook was that now the single line comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your pull request. Very much appreciated :) Now that we can write one-liners, I think this makes etk
a pretty good replacement for LLL
tests in ethereum/tests
.
This PR should allow to write one-liners as outlined in #43 such as