Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing the Boring crypto provider. #2

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Introducing the Boring crypto provider. #2

merged 1 commit into from
Apr 18, 2023

Conversation

nmittler
Copy link
Collaborator

@nmittler nmittler commented Mar 9, 2023

Also adding examples and basic documentation.

@nmittler
Copy link
Collaborator Author

nmittler commented Mar 9, 2023 •
edited
Loading

This is a WIP (won't currently build) and depends on quinn-rs/quinn#1496

@nmittler
Copy link
Collaborator Author

nmittler commented Mar 9, 2023

@djc FYI

@nmittler
Copy link
Collaborator Author

nmittler commented Mar 9, 2023 •
edited
Loading

@stevenctl @howardjohn A lot of BoringSSL code here .. who might be a good person on the Istio/Ambient side to review? Or maybe someone from Google Quiche might be more appropriate?

@nmittler nmittler mentioned this pull request Mar 10, 2023
Merged
nmittler
nmittler commented Mar 10, 2023
View reviewed changes
tests/integration_tests.rs
@@ -0,0 +1,643 @@
use anyhow::{anyhow, Result};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc meta question...

This effectively ports a subset of the quinn-proto unit tests to integration tests. In doing this I found a bug in my boringssl provider that was not caught by my previous hacking of the quinn-proto unit tests.

This makes me think that quinn should have these tests as well. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we'd be happy to extend test coverage in quinn and/or quinn-proto.

djc
djc reviewed Mar 13, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
tests/integration_tests.rs
@@ -0,0 +1,643 @@
use anyhow::{anyhow, Result};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we'd be happy to extend test coverage in quinn and/or quinn-proto.

tests/integration_tests.rs Show resolved Hide resolved
@nmittler nmittler force-pushed the boring branch 2 times, most recently from b4773e3 to 23dded1 Compare March 14, 2023 14:58
@nmittler nmittler mentioned this pull request Mar 27, 2023
Closed
nmittler added a commit to nmittler/quinn that referenced this pull request Mar 27, 2023
@nmittler
Bump quinn-proto version
0a41858 
Provides API changes needed by quinn-rs/quinn-boring#2.
@nmittler nmittler mentioned this pull request Mar 27, 2023
Merged
djc pushed a commit to quinn-rs/quinn that referenced this pull request Mar 28, 2023
@nmittler @djc
Bump quinn-proto version
ef20b50 
Provides API changes needed by quinn-rs/quinn-boring#2.
@nmittler nmittler force-pushed the boring branch 7 times, most recently from 66de094 to 14e2ffd Compare April 3, 2023 18:28
@nmittler nmittler mentioned this pull request Apr 4, 2023
Merged
@nmittler
Copy link
Collaborator Author

nmittler commented Apr 4, 2023 •
edited
Loading

@djc I'm seeing audit errors regarding the licenses: https://github.com/quinn-rs/quinn-boring/actions/runs/4612597441/jobs/8153674942?pr=2

Any idea what I might be doing wrong?

@nmittler nmittler force-pushed the boring branch 2 times, most recently from 5b82116 to 6a96e4a Compare April 5, 2023 13:31
@djc
Copy link
Member

djc commented Apr 5, 2023

You don't have a deny.toml file in your repo.

@nmittler nmittler force-pushed the boring branch 3 times, most recently from 2df56ec to 791e392 Compare April 5, 2023 15:03
@nmittler
Copy link
Collaborator Author

nmittler commented Apr 5, 2023

@djc that was it ... thank you! :)

@nmittler nmittler force-pushed the boring branch 6 times, most recently from 3021c54 to 2bb86ea Compare April 5, 2023 16:50
@nmittler nmittler force-pushed the boring branch 6 times, most recently from b87a119 to aaacbde Compare April 18, 2023 18:25
@nmittler
Introducing the Boring crypto provider.
95704ba 
Also adding examples and basic documentation.
@nmittler nmittler merged commit d7b1a4f into quinn-rs:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith left review comments

@djc djc djc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmittler @djc @Ralith