address code review

quinn-rs · Oct 26, 2023 · e52d51f · e52d51f
1 parent 5ecb025
commit e52d51f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/quinn-proto/src/connection/mod.rs b/quinn-proto/src/connection/mod.rs
@@ -483,7 +483,7 @@ impl Connection {
                     "PATH_CHALLENGE queued without 1-RTT keys"
                 );
 
-                if buf.capacity() < self.path.current_mtu() as usize {
+                if (buf.capacity() - buf.len()) < self.path.current_mtu() as usize {
                     buf.reserve(self.path.current_mtu() as usize - buf.capacity());
                 }
 
@@ -916,7 +916,7 @@ impl Connection {
                 None
             },
             segment_size: match num_datagrams {
-                1 | 0 => None,
+                1 => None,
                 _ => Some(self.path.current_mtu() as usize),
             },
             src_ip: self.local_ip,

diff --git a/quinn/src/connection.rs b/quinn/src/connection.rs
@@ -857,7 +857,9 @@ impl State {
         let mut transmits = 0;
 
         let max_datagrams = self.socket.max_transmit_segments();
-        let mut buffer = BytesMut::with_capacity(1500);
+        let capacity = 1500;
+        let mut buffer = BytesMut::with_capacity(capacity);
+
         while let Some(t) = self.inner.poll_transmit(now, max_datagrams, &mut buffer) {
             transmits += match t.segment_size {
                 None => 1,