Extract udp crate #1180
Merged
Extract udp crate #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2021
Ralith
previously requested changes
Sep 19, 2021
kpp
force-pushed
the
extract_udp_crate
branch
from
4953932
to
c93533e
Compare
|
Done. I also rebased onto main. |
djc
approved these changes
Sep 21, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is easy - moved code from quinn/platform into quinn-udp subcrate.
I will try to apply the code from https://github.com/ipfs-rust/udp-socket (which is runtime-agnostic due to use of
async-ioinstead oftokio) in the next PR.Fix #1178