Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent congestion fixes #1223

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Persistent congestion fixes #1223

merged 4 commits into from
Nov 4, 2021

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Nov 3, 2021

Minor correctness tweaks that should allow faster recovery and reduce spurious persistent congestion determinations.

RFC 9002 §6.2.1: When the PTO is armed for Initial or Handshake packet
number spaces, the max_ack_delay in the PTO period computation is set
to 0, since the peer is expected to not delay these packets
intentionally.
RFC 9002 §7.6.2: A sender establishes persistent congestion after the
receipt of an acknowledgment [...]
RFC 9002 §7.6.2: [..] a prior RTT sample existed when these two
packets were sent.
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@djc djc merged commit c35e61a into main Nov 4, 2021
@djc djc deleted the persistent-congestion branch November 4, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants