Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getters for stream concurrency metrics and related documentation #1518

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Getters for stream concurrency metrics and related documentation #1518

merged 1 commit into from
Mar 21, 2023

Conversation

FlorianUekermann
Copy link
Contributor

Would you prefer VarInts here?

Fixes #1517

djc
djc previously approved these changes Mar 18, 2023
View reviewed changes
@djc
Copy link
Member

djc commented Mar 18, 2023

Nice, thanks!

Ralith
Ralith requested changes Mar 19, 2023
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer VarInts here?

I lean towards no. I think the main benefit of VarInt is documenting range limitations on inputs; for outputs it's difficult to imagine any case where it wouldn't be unwrapped immediately, so we might as well skip the ceremony.

quinn-proto/src/connection/streams/state.rs Show resolved Hide resolved
quinn-proto/src/connection/streams/mod.rs Show resolved Hide resolved
quinn-proto/src/connection/streams/mod.rs Show resolved Hide resolved
@djc djc merged commit 93e7269 into quinn-rs:main Mar 21, 2023
@djc
Copy link
Member

djc commented Mar 21, 2023

Thanks!

@djc djc mentioned this pull request May 8, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proto: Provide explicit MAX_STREAMS control.
3 participants
@FlorianUekermann @djc @Ralith