-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade socket2 to 0.5 #1558
Upgrade socket2 to 0.5 #1558
Conversation
1e39c8d
to
e5cbbe4
Compare
2da390f
to
9550d86
Compare
The CI failure here is confusing. Tokio's support for |
The MSRV issue is a tokio bug, PR in tokio-rs/tokio#5677. |
I tested this locally with djc-2021 socket2-0.5 quinn $ git diff
diff --git a/Cargo.toml b/Cargo.toml
index 6a985fb6..ca92f1c2 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -7,3 +7,6 @@ debug = true
[profile.release]
debug = true
+
+[patch."crates-io"]
+tokio = { path = "../tokio/tokio" } (with the aforelinked PR checked out) and it seems to be fine:
So I don't think we need to block the release on the MSRV issue? We can mention it as a caveat in the release notes. |
@Ralith requested re-review since this now has a bunch of extra stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements overall!
Bumped the tokio dependency in quinn to 1.28.1 which should make the MSRV test pass. |
This should be okay now that we've bumped our MSRV?