Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1685, applied to main #1686

Merged
merged 2 commits into from
Dec 18, 2023
Merged

#1685, applied to main #1686

merged 2 commits into from
Dec 18, 2023

Conversation

jeromegn
Copy link
Contributor

No description provided.

@jeromegn jeromegn mentioned this pull request Oct 14, 2023
Closed
2 tasks
@djc
Copy link
Member

djc commented Oct 21, 2023

Can you rebase everything (that needs it) from the merged version of #1685?

@Ralith
Copy link
Collaborator

Ralith commented Dec 17, 2023

@jeromegn do you think you'll find time to finish this?

@jeromegn
Copy link
Contributor Author

I have rebased main and clippy looks good now.

Ralith
Ralith approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc merged commit 383ac35 into quinn-rs:main Dec 18, 2023
8 checks passed
@Ralith Ralith mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromegn @djc @Ralith