Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: yield transport error for Initial packets with no CRYPTO #1721

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

djc
Copy link
Member

@djc djc commented Dec 7, 2023

No description provided.

@djc djc requested a review from Ralith December 7, 2023 12:10
@djc djc force-pushed the err-no-crypto-initial branch from 3d977be to 93a88ae Compare December 11, 2023 14:17
@Ralith
Copy link
Collaborator

Ralith commented Dec 11, 2023

From Windows CI:

test tests::handshake_anti_deadlock_probe has been running for over 60 seconds
memory allocation of 24696061952 bytes failed

That's a bit spooky.

@djc djc force-pushed the err-no-crypto-initial branch from 93a88ae to d200bb4 Compare December 19, 2023 10:51
@djc
Copy link
Member Author

djc commented Dec 19, 2023

Reverted this to the initial approach, but updated the RFC comment to more closely match the code.

@Ralith Ralith merged commit 470b213 into main Dec 19, 2023
8 checks passed
@Ralith Ralith deleted the err-no-crypto-initial branch December 19, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants