Enable use of aws-lc-rs instead of ring #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
aws-lc-rs
branch
3 times, most recently
from
79d62a0
to
267ccbb
Compare
Ralith
reviewed
Aug 8, 2024
Merged
|
Would you provide an option to disable both aws-lc-rs and ring? I would like to try another third-party adapter. |
This should already be the case both in released versions and once this PR is merged. |
djc
force-pushed
the
aws-lc-rs
branch
4 times, most recently
from
4e808d4
to
424502f
Compare
|
Addressed comments and added CI job to test this. |
Ralith
approved these changes
Sep 23, 2024
|
I think we should consider that for 0.12. For now, I don't think we want to switch the default crypto provider in a semver-compatible release, and I also think it might be surprising if the default is not the implementation that gets used if both providers are enabled (since other crates in the dependency graph can do that "behind your back"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs a CI workflow to ensure that this actually works.