crypto: expose negotiated_cipher_suite in the hadshake data #2001
Conversation
| @@ -256,6 +261,9 @@ pub struct HandshakeData { | |||
| /// | |||
| /// Always `None` for outgoing connections | |||
| pub server_name: Option<String>, | |||
|
|
|||
| /// The ciphersuite negotiated with the peer. | |||
| pub negotiated_cipher_suite: CipherSuite, | |||
There was a problem hiding this comment.
I think it might be better to avoid using a rustls-specific type here.
There was a problem hiding this comment.
Yeah, but on the other hand why not? :D
This is rustls.rs module, which already depends on rustls specific (and quinn re-export rustls as well)
There was a problem hiding this comment.
But if we're going to have a rustls-specific type, why not SupportedCipherSuite instead of CipherSuite?
@Ralith have opinions on this?
There was a problem hiding this comment.
SupportedCipherSuite also contains the implementation.
I thought the scope of this crypto::rustls::HandshakeData for quinn is just give the information about the negotiated cipher and implementation is not needed (reducing overhead of the struct); that's why I went for CipherSuite instead.
Anyway lemme know what do you prefer
Once |
As title.
I am not totally convinced by that
.expect("cipher is negotiated").It makes sense to me: as AFAIK reaching that point always implies the cipher is negotiated, but I might have missed a edge scenario