Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quinn, quinn-proto): add aws-lc-rs-fips feature flag #2003

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

M0dEx
Copy link

@M0dEx M0dEx commented Oct 7, 2024

Adds support for aws-lc-rs FIPS mode using a feature flag in quinn and quinn-proto.

Adds support for aws-lc-rs FIPS mode using a feature flag in quinn and quinn-proto.
@M0dEx
Copy link
Author

M0dEx commented Oct 7, 2024

Seems the tests finished, but the features workflow has an issue due to a missing golang dependency of the FIPS mode.

@djc
Copy link
Member

djc commented Oct 7, 2024

Maybe have a look at how rustls exercises that stuff in CI?

@M0dEx
Copy link
Author

M0dEx commented Oct 8, 2024

Maybe have a look at how rustls exercises that stuff in CI?

It seems the FIPS module has some untrivial dependencies as far as GitHub Actions are concerned (you need to manually install Go on the macos-latest runner, Ninja on the windows-latest runner, etc.)

The rustls project uses only the ubuntu-latest for feature combination checks, but I assume this project had a reason to have those run in a matrix over different OS's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants