Explicitly fill scrollable height to fill

This fixes an issue where Fill-width elements in the column would disappear, maybe because of these issues: iced-rs/iced#715 iced-rs/iced#2186 iced-rs/iced#2192
quintenpalmer · Feb 15, 2024 · 56c4cc9 · 56c4cc9
1 parent f5dd56c
commit 56c4cc9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/app/src/gui/view/page/pages/albums.rs b/src/app/src/gui/view/page/pages/albums.rs
@@ -106,7 +106,7 @@ pub fn album_list<'a>(
                     }
                 }
 
-                let scrollable = Scrollable::new(columns.width(Length::Fill));
+                let scrollable = Scrollable::new(columns.width(Length::Fill)).height(Length::Fill);
                 Container::new(
                     Column::new()
                         .spacing(10)

diff --git a/src/app/src/gui/view/page/pages/artist.rs b/src/app/src/gui/view/page/pages/artist.rs
@@ -92,7 +92,7 @@ pub fn artist_list<'a>(
                     }
                 }
 
-                let scrollable = Scrollable::new(columns.width(Length::Fill));
+                let scrollable = Scrollable::new(columns.width(Length::Fill)).height(Length::Fill);
                 Container::new(
                     Column::new()
                         .spacing(10)

diff --git a/src/app/src/gui/view/page/pages/movielist.rs b/src/app/src/gui/view/page/pages/movielist.rs
@@ -204,7 +204,7 @@ pub fn movie_list<'a>(
                     .push(h1("Movies"))
                     .push(page_buttons)
                     .push(extra_page_buttons)
-                    .push(Scrollable::new(columns.width(Length::Fill))),
+                    .push(Scrollable::new(columns.width(Length::Fill)).height(Length::Fill)),
             );
 
             (breadcrumbs, body)

diff --git a/src/app/src/gui/view/page/pages/tracks.rs b/src/app/src/gui/view/page/pages/tracks.rs
@@ -105,7 +105,7 @@ pub fn track_list<'a>(
 
                 let grid: Element<Message> = columns.into();
 
-                let scrollable = Scrollable::new(grid);
+                let scrollable = Scrollable::new(grid).height(Length::Fill);
 
                 let mut total_tracks = 0;
                 for (_, artist) in library.get_artist_map().iter() {