Skip to content

Commit

Permalink
Make Service Icons work as enum was wrong (woodpecker-ci#3148)
Browse files Browse the repository at this point in the history
  • Loading branch information
6543 authored and fernandrone committed Feb 1, 2024
1 parent 5b55be1 commit 168d846
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions web/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ declare module 'vue' {
InputField: typeof import('./src/components/form/InputField.vue')['default']
IPhGitlabLogoSimpleFill: typeof import('~icons/ph/gitlab-logo-simple-fill')['default']
ISimpleIconsGitea: typeof import('~icons/simple-icons/gitea')['default']
ISvgSpinners180RingWithBg: typeof import('~icons/svg-spinners/180-ring-with-bg')['default']
ITeenyiconsGitSolid: typeof import('~icons/teenyicons/git-solid')['default']
ITeenyiconsRefreshOutline: typeof import('~icons/teenyicons/refresh-outline')['default']
IVaadinQuestionCircleO: typeof import('~icons/vaadin/question-circle-o')['default']
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/repo/pipeline/PipelineStepList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
}"
@click="$emit('update:selected-step-id', step.pid)"
>
<PipelineStatusIcon :service="step.type == StepType.Service" :status="step.state" class="!h-4 !w-4" />
<PipelineStatusIcon :service="step.type === StepType.Service" :status="step.state" class="!h-4 !w-4" />
<span class="truncate">{{ step.name }}</span>
<PipelineStepDuration :step="step" />
</button>
Expand Down
10 changes: 5 additions & 5 deletions web/src/lib/api/types/pipeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ export type PipelineFeed = Pipeline & {
};

export enum StepType {
Clone = 1,
Service,
Plugin,
Commands,
Cache,
Clone = 'clone',
Service = 'service',
Plugin = 'plugin',
Commands = 'commands',
Cache = 'cache',
}

0 comments on commit 168d846

Please sign in to comment.