Enable nolintlint (woodpecker-ci#3158)

quintoandar · Feb 1, 2024 · 67a5a9f · 67a5a9f
1 parent a2488e1
commit 67a5a9f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -161,6 +161,7 @@ linters:
     - unparam
     - wastedassign
     - whitespace
+    - nolintlint
 
 run:
   timeout: 15m

diff --git a/pipeline/frontend/yaml/compiler/errors.go b/pipeline/frontend/yaml/compiler/errors.go
@@ -25,7 +25,7 @@ func (err *ErrExtraHostFormat) Error() string {
 }
 
 func (*ErrExtraHostFormat) Is(target error) bool {
-	_, ok := target.(*ErrExtraHostFormat) //nolint:errorlint
+	_, ok := target.(*ErrExtraHostFormat)
 	return ok
 }
 
@@ -39,7 +39,7 @@ func (err *ErrStepMissingDependency) Error() string {
 }
 
 func (*ErrStepMissingDependency) Is(target error) bool {
-	_, ok := target.(*ErrStepMissingDependency) //nolint:errorlint
+	_, ok := target.(*ErrStepMissingDependency)
 	return ok
 }
 
@@ -52,6 +52,6 @@ func (err *ErrStepDependencyCycle) Error() string {
 }
 
 func (*ErrStepDependencyCycle) Is(target error) bool {
-	_, ok := target.(*ErrStepDependencyCycle) //nolint:errorlint
+	_, ok := target.(*ErrStepDependencyCycle)
 	return ok
 }
diff --git a/server/forge/types/errors.go b/server/forge/types/errors.go
@@ -54,7 +54,7 @@ func (err *ErrIgnoreEvent) Error() string {
 }
 
 func (*ErrIgnoreEvent) Is(target error) bool {
-	_, ok := target.(*ErrIgnoreEvent) //nolint:errorlint
+	_, ok := target.(*ErrIgnoreEvent)
 	return ok
 }
 
@@ -67,6 +67,6 @@ func (m *ErrConfigNotFound) Error() string {
 }
 
 func (*ErrConfigNotFound) Is(target error) bool {
-	_, ok := target.(*ErrConfigNotFound) //nolint:errorlint
+	_, ok := target.(*ErrConfigNotFound)
 	return ok
 }
diff --git a/server/pipeline/errors.go b/server/pipeline/errors.go
@@ -25,9 +25,9 @@ func (e ErrNotFound) Error() string {
 }
 
 func (e ErrNotFound) Is(target error) bool {
-	_, ok := target.(ErrNotFound) //nolint:errorlint
+	_, ok := target.(ErrNotFound)
 	if !ok {
-		_, ok = target.(*ErrNotFound) //nolint:errorlint
+		_, ok = target.(*ErrNotFound)
 	}
 	return ok
 }
@@ -41,9 +41,9 @@ func (e ErrBadRequest) Error() string {
 }
 
 func (e ErrBadRequest) Is(target error) bool {
-	_, ok := target.(ErrBadRequest) //nolint:errorlint
+	_, ok := target.(ErrBadRequest)
 	if !ok {
-		_, ok = target.(*ErrBadRequest) //nolint:errorlint
+		_, ok = target.(*ErrBadRequest)
 	}
 	return ok
 }