This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Fix Double Free in KeyValues #include macro
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if this is the bug that the [valvesoftware wiki mentions](https://developer.valvesoftware.com/wiki/KeyValues#About_KeyValues_Text_File_Format:), but I have experienced memory corruption and segfaults (in other source games) from this bug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the bug that the valvesoftware wiki mentions, but I have experienced memory corruption and segfaults (in other source games) from this bug.
Basically, the
AppendIncludedKeysfunction appends the includedKeyValuesdirectly, without reallocating. Then, the included KeyValues are freed, while in use.This commit removes the free.