Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopIII Simulation #368

Merged
merged 212 commits into from
Feb 5, 2024
Merged

PopIII Simulation #368

merged 212 commits into from
Feb 5, 2024

Conversation

psharda
Copy link
Contributor

@psharda psharda commented Sep 8, 2023

This PR will add a PopIII simulation to quokka. It will only test that the simulation starts successfully and runs for a few timesteps - it's not meant to be a production simulation.

@psharda psharda added this to the Microphysics integration milestone Sep 8, 2023
@psharda
Copy link
Contributor Author

psharda commented Sep 8, 2023

/azp run

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/Chemistry.hpp Outdated Show resolved Hide resolved
src/PopIII/TurbDataReader.cpp Outdated Show resolved Hide resolved
src/PopIII/popiii.cpp Outdated Show resolved Hide resolved
src/PopIII/popiii.cpp Show resolved Hide resolved
src/PopIII/popiii.cpp Show resolved Hide resolved
psharda and others added 2 commits September 8, 2023 12:51
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@psharda
Copy link
Contributor Author

psharda commented Feb 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@psharda
Copy link
Contributor Author

psharda commented Feb 4, 2024

all tests should pass now

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/Chemistry.hpp Outdated Show resolved Hide resolved
src/PopIII/CMakeLists.txt Show resolved Hide resolved
src/PopIII/popiii.cpp Outdated Show resolved Hide resolved
src/PopIII/popiii.cpp Outdated Show resolved Hide resolved
src/PopIII/popiii.cpp Outdated Show resolved Hide resolved
src/PopIII/popiii.cpp Show resolved Hide resolved
src/PopIII/popiii.cpp Show resolved Hide resolved
src/PopIII/popiii.cpp Show resolved Hide resolved
tests/PopIII.in Outdated Show resolved Hide resolved
@psharda
Copy link
Contributor Author

psharda commented Feb 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@psharda psharda self-assigned this Feb 5, 2024
@psharda
Copy link
Contributor Author

psharda commented Feb 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@BenWibking
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@BenWibking BenWibking added this pull request to the merge queue Feb 5, 2024
Merged via the queue into quokka-astro:development with commit 93686aa Feb 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants