[WIP] use 5th-order hybrid PPM/WENO reconstruction #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
changed the title
|
HydroBlast3D test does not conserve energy. Is this because of the pressure floor? Or a bug in the flux correction? This issue blocks merging into development. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the 5th-order, extrema-preserving, hybrid PPM-WENO reconstruction method of Rider, Greenough, and Kamm (2007): https://ui.adsabs.harvard.edu/abs/2007JCoPh.225.1827R/abstract
The number of ghost zones required is the same as PPM (4, if shock flattening is enabled).
Note that only the reconstruction is 5th-order. The overall order of accuracy in space in still 2nd order.
Depends on #74.