Generate fun quotes when compiling quokka #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
BenWibking
reviewed
Aug 27, 2024
| @@ -70,3 +70,5 @@ add_subdirectory(${QuokkaCode_SOURCE_DIR}/extern/yaml-cpp ${QuokkaCode_BINARY_DI | |||
| add_definitions(-DNAUX_NET -DSTRANG) | |||
| add_subdirectory(${QuokkaCode_SOURCE_DIR}/extern/Microphysics ${QuokkaCode_BINARY_DIR}/Microphysics) | |||
| add_subdirectory(${QuokkaCode_SOURCE_DIR}/src ${QuokkaCode_BINARY_DIR}/src) | |||
|
|
|||
| execute_process(COMMAND python3 "${CMAKE_SOURCE_DIR}/scripts/quotes.py") | |||
There was a problem hiding this comment.
You should just call fortune. It's on every Mac and Linux system:
FORTUNE(1) General Commands Manual FORTUNE(1)
NAME
fortune - sample lines from a file
SYNOPSIS
fortune [ file ]
DESCRIPTION
Fortune prints a one-line aphorism chosen at random. If a file is specified, the saying is taken from that file;
otherwise it is selected from /lib/fortunes.
FILES
/lib/fortunes
/lib/fortunes.index fast lookup table, maintained automatically
SOURCE
/src/cmd/fortune.c
BenWibking
reviewed
Aug 27, 2024
There was a problem hiding this comment.
If you are going to supply a custom file of fortunes, you can't rip them off someone else. They have to be Quokka-specific. And ideally about quokkas.
|
@psharda, do you still want to proceed with this, or can I close it off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wouldn't it be fun to see a random (possibly funny, definitely geeky) quote every time you compile Quokka? Just type
cmake ..and see the magic.Related issues
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.