Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe don't use a different text color for highlighted events #370

Closed
KitsuneRal opened this issue Jun 23, 2018 · 3 comments
Closed

Maybe don't use a different text color for highlighted events #370

KitsuneRal opened this issue Jun 23, 2018 · 3 comments
Assignees
Labels
enhancement A feature or change request for Quaternion

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Jun 23, 2018

The highlight color is (by default) alarming enough to make the text in that color less readable - especially if the text is long (see https://matrix.to/#/!YkZelGRiqijtzXZODa:matrix.org/$15296800015801znPgI:t2l.io and the message leading to it). So either that should be a frame around the event, or background in that color instead (in case of background it of course should be a tint over the background color).

@rushsteve1
Copy link
Contributor

rushsteve1 commented Jun 23, 2018

Ideally this should be configurable.
But for now what do you think of bolding instead of highlighting? And then perhaps slightly coloring (all?) nicknames to distinguish them.

@KitsuneRal
Copy link
Member Author

Nicknames tinting is a separate thing that would be great to do. As for bold text - to be frank, I'm not a big fan of that either.
Configurability - well... People have strong opinions on whether "everything should be configurable" :) Being a former GNOME person, I prefer keeping options under close control.
I tend to choosing the frame or some kind of a marker instead. As the least change from the current, colour-highlighting the specific word/nick that caused the protocol highlighting of the event should be much less intrusive than highlighting the entire text.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Jul 7, 2018
@KitsuneRal KitsuneRal self-assigned this Aug 12, 2018
@KitsuneRal
Copy link
Member Author

As of the commit above, the highlighting mode is configurable between background/text but not exposed in UI. Using a frame for highlighting didn't look good but if anybody wants I can make it available too (it's really easy now).

@KitsuneRal KitsuneRal moved this to Versions 0.0.9.1-3 - Released in Quaternion 1 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for Quaternion
Projects
Status: Versions 0.0.9.1-3 - Released
Development

No branches or pull requests

2 participants