Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the maximum height for ChatEdit #443

Closed
wants to merge 1 commit into from
Closed

Set the maximum height for ChatEdit #443

wants to merge 1 commit into from

Conversation

krkk
Copy link
Contributor

@krkk krkk commented Oct 28, 2018

Closes #246

KitsuneRal
KitsuneRal requested changes Oct 28, 2018
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid it's not that easy. Why 200? Can you bind the maximum height to something else in UI instead (the size of the owning widget, e.g.)?

@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Nov 17, 2018
@KitsuneRal KitsuneRal closed this Jan 15, 2019
@KitsuneRal
Copy link
Member

Sorry, will re-implement it on my end.

@krkk krkk deleted the MaxHeightChatEdit branch January 15, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal requested changes

Assignees
No one assigned
Labels
enhancement A feature or change request for Quaternion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krkk @KitsuneRal