add support for qtkeychain to store access tokens #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsdgeos
reviewed
Feb 7, 2019
KitsuneRal
requested changes
Feb 10, 2019
There was a problem hiding this comment.
Overall - this looks totally gorgeous; many thanks for the effort. I haven't tried it on Windows yet but I'm fine to merge even if this only works on Linux.
Aside from addressing a few comments below, consider adding QtKeychain to .travis.yml so that we could maintain buildability of this across platforms. (Adding it to .appveyor.yml as well would be even greater but optional for now.)
ddanilov
force-pushed
the
keychain
branch
2 times, most recently
from
843bd26 to
dc6938d
Compare
KitsuneRal
requested changes
Feb 10, 2019
KitsuneRal
approved these changes
Feb 17, 2019
Also seems to work great on Mac!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.