Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access token invalidation leaves Quaternion in a stalemate #316

Closed
KitsuneRal opened this issue Sep 8, 2018 · 3 comments
Closed

Access token invalidation leaves Quaternion in a stalemate #316

KitsuneRal opened this issue Sep 8, 2018 · 3 comments
Assignees
Labels
bug/fix The library doesn't work as expected

Comments

@KitsuneRal
Copy link
Member

The current behaviour is that the next sync fails with an error window that proposes an escape path through logout (not bad already) but trying to actually logout ends up with another "Invalid access token" error, with the list of rooms staying intact. The access token gets deleted though; so on the next run Quaternion would ask for login credentials instead of failing again.

What should be: upon receiving M_UNKNOWN_TOKEN, Quaternion should cleanup the interface as if this connection wasn't there and show the login window with all data except password prefilled.

When the library supports it, internally the connection might not even be deleted; rather, a way to update the access token is provided so that the next sync could go on as if nothing happened (with the previous batch token and all the rooms etc. being there). This would make re-logging-in as painless as possible.

@KitsuneRal
Copy link
Member Author

In the light of recent access token invalidations this becomes pretty urgent.

@KitsuneRal KitsuneRal self-assigned this Apr 14, 2019
@KitsuneRal
Copy link
Member Author

Turns out the more or less reasonable way out of this is already in Quaternion but is not taken due to a bug in the library.

@KitsuneRal KitsuneRal transferred this issue from quotient-im/Quaternion Apr 15, 2019
@KitsuneRal KitsuneRal added the bug/fix The library doesn't work as expected label Apr 15, 2019
KitsuneRal added a commit that referenced this issue Apr 16, 2019
@KitsuneRal
Copy link
Member Author

This is fixed by the commits above.

KitsuneRal added a commit that referenced this issue Apr 24, 2019
@KitsuneRal KitsuneRal moved this to Version 0.5(.x) - Released in libQuotient 1 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix The library doesn't work as expected
Projects
Status: Version 0.5(.x) - Released
Development

No branches or pull requests

1 participant