Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event replacement API spans two classes #490

Closed
KitsuneRal opened this issue Aug 2, 2021 · 0 comments · Fixed by #578
Closed

Event replacement API spans two classes #490

KitsuneRal opened this issue Aug 2, 2021 · 0 comments · Fixed by #578
Assignees
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Aug 2, 2021

The API is spread across RoomMessageEvent and RoomEvent; the main reason for that seems to be that when the event is getting replaced, the data for the replacing event are put in unsigned and not in content JSON dictionary; but replacing an event with a non-message is not a good thing anyway. For now it makes sense to move isReplaced() and replacedBy() to RoomMessageEvent; and we'll see what MSC1849 will bring us.

MSC1849 was split in several other ones; the relevant one here is MSC2676 and it just landed in the spec. The way it's currently worded basically requires the replaced (and the replacing) event to be of m.room.message type. Rules out editing stickers (and replying to/with them), heh.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Aug 2, 2021
@KitsuneRal KitsuneRal self-assigned this Oct 16, 2022
KitsuneRal added a commit that referenced this issue Oct 16, 2022
@KitsuneRal KitsuneRal moved this to Version 0.7 - Done in libQuotient 1 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
Status: Version 0.7 - Done
Development

Successfully merging a pull request may close this issue.

1 participant