Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce intrinsic constant tuple DEFAULT_ODE_SOLVER_OPTIONS #172

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

ytdHuang
Copy link
Member

The default keyword arguments for ODE solvers are:

  • abstol = 1e-8
  • reltol = 1e-6
  • save_everystep = false : this can avoid storing all the internal states in sol.u if users set saveat = []
  • save_end = true

This PR also add some runtests for sesolve and mesolve.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (c5da8e2) to head (248f872).

Current head 248f872 differs from pull request most recent head 582bbf9

Please upload reports for the commit 582bbf9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   93.22%   93.21%   -0.01%     
==========================================
  Files          28       28              
  Lines        2051     2049       -2     
==========================================
- Hits         1912     1910       -2     
  Misses        139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang changed the title introduce intrinsic constant tuple _Default_ODE_Solver_Options introduce intrinsic constant tuple DEFAULT_ODE_SOLVER_OPTIONS Jun 21, 2024
@albertomercurio albertomercurio merged commit 71e5b5d into qutip:main Jun 23, 2024
12 checks passed
@ytdHuang ytdHuang deleted the dev/default_ode_option branch June 23, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants