Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous PR, I fixed the type instabilities of the
sesolve
function.However, a weak type instability was still present at the level of the
ODEProblem
generation. By weak I mean that the type of theODEProblem
was known up to aUnion
.Fixing this will help me on fixing type instabilities for the
mesolve
andmcsolve
functions.I think that I have introduced a very smat way to deal with multiple dispatch with keyword arguments. For example, the
progress_bar
argument now supports both aBool
type and aVal
type, with the second one as a default to avoid weak type instabilities. In this way, the user can still useprogress_bar = true,false
, with the price to pay of having weak type instabilities.