Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect times in time evolution solutions #244

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Sep 29, 2024

Description

The current times of different time evolution solutions are basically obtained from sol.t.
However, the length of sol.t actually depends on the keyword argument saveat.

To make it consistent with the docstrings, and also align with QuTiP, I put t_l into p = (..., times = t_l, ...), and then pass it to different time evolution solutions with sol.prob.p.times.

After this PR, the type of sol.times are all the same as Vector{<:Real} for different time evolution solutions, and the length should be equal to the input tlist.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.55%. Comparing base (1913fd9) to head (fc15507).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/time_evolution/lr_mesolve.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   94.40%   93.55%   -0.85%     
==========================================
  Files          31       31              
  Lines        2268     2266       -2     
==========================================
- Hits         2141     2120      -21     
- Misses        127      146      +19     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 905e658 into qutip:main Sep 29, 2024
9 of 11 checks passed
@ytdHuang ytdHuang deleted the fix/solution branch September 29, 2024 08:50
albertomercurio pushed a commit to albertomercurio/QuantumToolbox.jl that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants