Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce convert_unit #255

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Oct 4, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributor Covenant Code of Conduct
  • Any code changes were done in a way that does not break public API
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Summarize of this PR:

  • Introduce convert_unit, which is the similar function in qutip (see here for the github code)
  • add runtests (and also type inferrence tests) for utility functions

@ytdHuang ytdHuang changed the title Introduce \convert_unit\ Introduce convert_unit Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (bde9142) to head (eeb796f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   94.48%   93.51%   -0.98%     
==========================================
  Files          31       31              
  Lines        2267     2297      +30     
==========================================
+ Hits         2142     2148       +6     
- Misses        125      149      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 51684ab into qutip:main Oct 4, 2024
10 of 11 checks passed
@ytdHuang ytdHuang deleted the dev/convert_unit branch October 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants