Fix lcd/tcd #1078
Merged
Fix lcd/tcd #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code path effectively turned any `lcd` or `tcd` into a `cd`. - `lcd` (or `tcd`) from nvim - handled by `DirChanged` autocmd from NvimView.swift - fires `.dirchanged` event - handled by autoCommandEvent() in NvimView+UiBridge.swift - calls cwdChanged() in NvimView+UiBridge.swift - fires event `.cwdChanged` - handled by `subscribeToNvimViewEvents()` in MainWindow.swift - calls `cwdChanged()` in MainWindow+Delegates.swift - fires even `.cd` - handled by `typedReduce()` in MainWindowReducer.swift - sets `state.cwdToSet` - state change handled by `subscribeToStateChange()` in MainWindow.swift - sets `self.neoVimView.cwd` - handled by `var cwd` setter in NvimView.swift - calls `nvimSetCurrentDir()` which sets global nvim cwd This chain had to be broken somewhere. The `state.cwdToSet` line in MainWindowReducer.swift has a comment that it's set to "ensure updates also send to tab bar". To fix we remove that line and instead set the tab bar cwd earlier in the cahin in NvimView+UiBridge.swift. I don't normally use the custom tab bar or file browser, but have tested them with this change and they seem to still work well. Fixes qvacua#1027
|
This is fantastic and was also on my list to look at. Thanks!
There was some confusion due to lcd not working right which caused me to make the change. I think it related to the browser not getting updated on tab switch.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code path effectively turned any
lcdortcdinto acd.lcd(ortcd) from nvimDirChangedautocmd from NvimView.swift.dirchangedevent.cwdChangedsubscribeToNvimViewEvents()in MainWindow.swiftcwdChanged()in MainWindow+Delegates.swift.cdtypedReduce()in MainWindowReducer.swiftstate.cwdToSetsubscribeToStateChange()in MainWindow.swiftself.neoVimView.cwdvar cwdsetter in NvimView.swiftnvimSetCurrentDir()which sets global nvim cwdThis chain had to be broken somewhere. The
state.cwdToSetline in MainWindowReducer.swift has a comment that it's set to "ensure updates also send to tab bar". To fix we remove that line and instead set the tab bar cwd earlier in the cahin in NvimView+UiBridge.swift.I don't normally use the custom tab bar or file browser, but have tested them with this change and they seem to still work well.
Fixes #1027