Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom markdown processor setting #745

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

ernstwi
Copy link
Contributor

@ernstwi ernstwi commented Aug 17, 2019

Hello! Thanks for all the work on VimR.

This allows users to set a shell command to run instead of the default markdown processor. I saw there were some issues asking for different markdown features, which is probably unavoidable since there are so many variants of markdown. Personally I use pandoc with a lot of flags to get the specific markdown variant I prefer.

This is a work in progress but I wanted to get your input. Do you think this is a good idea? I was also unsure of where to put the setting. It is currently under "General" which I'm sure is not right, but should it go under "Tools" or "Advanced"? Or maybe in the cogwheel menu at the top of the preview window?

@qvacua
Copy link
Owner

qvacua commented Oct 4, 2019

Sorry for the late response. I think that the Advanced would do fine.

@qvacua
Copy link
Owner

qvacua commented Dec 25, 2019

I'm very sorry for being late. IMO "Advanced" would be the best fit for this setting. The forward and reverse search should be disabled without changing the settings value when a custom renderer is set. Also, one should check that the renderer exists when setting it.

@jottr
Copy link

jottr commented Apr 23, 2021

@ernstwi did you give up on this feature?

@qvacua did you ever try out the PR?

@ernstwi
Copy link
Contributor Author

ernstwi commented Apr 25, 2021

@jottr Sorry yes, I did give up on this.

In my case I already had a wiki server running locally which renders markdown how I like it, so it was more convenient to use VimR's HTML preview. I added a command VimRReloadWebview which takes an URL parameter. This let me sync HTML preview to the active buffer.

@qvacua
Copy link
Owner

qvacua commented Oct 31, 2023

I'm sorry for being mute for some time. I've been inactive due to some private reasons. I'll get slowly get restarted and go through all PRs.

@qvacua qvacua marked this pull request as ready for review November 5, 2023 18:54
@qvacua qvacua merged commit 94df77a into qvacua:develop Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants