Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color system tray icons on MacOS are broken #1221

Closed
tresf opened this issue Nov 26, 2023 · 1 comment
Closed

Color system tray icons on MacOS are broken #1221

tresf opened this issue Nov 26, 2023 · 1 comment
Assignees
@tresf
Labels
bug

Comments

@tresf
Copy link
Contributor

tresf commented Nov 26, 2023

This predominantly breaks Company Branded builds which don't use QZ Tray's artwork.

It looks like we accidentally reverted this behavior in c0e20f3.

tray/ant/unix/unix-launcher.sh.in

Line 128 in e329cb4

java $LAUNCH_OPTS -Xdock:name="$ABOUT_TITLE" -Xdock:icon="$DIR/../Resources/$PROPS_FILE.icns" -jar -Dapple.awt.UIElement="true" -Dapple.awt.enableTemplateImages="true" -Dapple.awt.application.appearance="system" "$DIR/../Resources/${prefix}$PROPS_FILE.jar" -NSRequiresAquaSystemAppearance False "$@"

@tresf tresf added the bug label Nov 26, 2023
@tresf tresf self-assigned this Nov 26, 2023
tresf added a commit that referenced this issue Nov 26, 2023
@tresf
Fix color system tray icons for Company Branded builds
ca31751 
Per #1221
tresf added a commit that referenced this issue Nov 28, 2023
@tresf
Fix color system tray icons for Company Branded builds
3b1d953 
Per #1221
@tresf
Copy link
Contributor Author

tresf commented Nov 28, 2023 •
edited
Loading

Closed via 3b1d953. Note, Company Branded builds will still be wrong, we'll have to write a retroactive patch. Edit: Done, PR opened (private).

@tresf tresf closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tresf tresf

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tresf