Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs #59

Merged
merged 87 commits into from
Nov 14, 2019
Merged

Docs #59

merged 87 commits into from
Nov 14, 2019

Conversation

maelle
Copy link
Member

@maelle maelle commented Oct 29, 2019

cf #58, here's what I suggest

  • Make README shorter, put search details into a vignette.
  • Re-work pkgdown navbar and reference.
  • Add extra.css otherwise the table of contents of the search vignette looks bad

In the local installed version users would see the package level docs, the vignette about search, and for other features I think the function index is enough (so no need to reproduce the README content as a vignette?)

@maelle maelle requested a review from gaborcsardi October 29, 2019 11:45
@maelle maelle mentioned this pull request Oct 29, 2019
Open
@maelle maelle mentioned this pull request Oct 31, 2019
Closed
gaborcsardi
gaborcsardi approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments.

README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented Nov 12, 2019

The mp4 to gif conversion went wrong 🤔

@maelle
Copy link
Member Author

maelle commented Nov 12, 2019

Not sure what to think of the LaTeX travis failure.

@maelle
Copy link
Member Author

maelle commented Nov 12, 2019

The GIF is much too big atm

@gaborcsardi
Refine package list formatting
56e505b 
Put title on top, metadata below.
@gaborcsardi
Refine action icon
a3a5dee
@gaborcsardi
Include all package names in dependency error
abafcfc
@gaborcsardi
Fix GH action icon
ab5e686
@gaborcsardi
Logo link to R-hub
c37d279
@gaborcsardi
Remove unused code
ed24bd5
@gaborcsardi
Avoid magrittr dependency
2d9453d
@gaborcsardi
Qualify functions from shiny
a750d09
@gaborcsardi
No need to import dotenv
53468eb
@gaborcsardi
Fix examples
5bc4c66 
Use \dontshow{} and check for internet connection.

Closes #60.
@gaborcsardi
Brush up NEWS
d1bdf8d
@gaborcsardi
Add NEWS about the addin
928d7ad 
Closes #74.
@gaborcsardi
Fix missing arguments in manual
17d4369
@gaborcsardi
format_results() -> format_addin_results()
f4b8026 
To avoid confusion with the format_result() function.
@gaborcsardi
Fix more() for advanced_search()
8573852 
Closes #64.
@gaborcsardi
Trying to fix conditional examples of older R versions
6123198 
That do not have withAutoprint().
@gaborcsardi
Still trying to fix examples on old R
4491fe5 
Some source() arguments are new.
@gaborcsardi
No need for methods package
7326fdc
@gaborcsardi
It is enough to suggest 'whoami'
70d2874 
It is only used in the addin.
@gaborcsardi
Update errors.R to 1.2.0
325d73d
@gaborcsardi
Use errors.R, and improve errors from server
260f1e3 
Closes #61.
@gaborcsardi
Add VignetteBuilder field to DESCRIPTION
5ffb5ff
@gaborcsardi gaborcsardi merged commit 8ef39cc into master Nov 14, 2019
@gaborcsardi gaborcsardi deleted the readme branch November 14, 2019 10:16
@gaborcsardi gaborcsardi mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @gaborcsardi