Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.url style should probably use style_hyperlink() #386

Closed
gaborcsardi opened this issue Jan 6, 2022 · 3 comments
Closed

.url style should probably use style_hyperlink() #386

gaborcsardi opened this issue Jan 6, 2022 · 3 comments
Labels
feature a feature request or enhancement
Milestone
3.4.0

Comments

@gaborcsardi
Copy link
Member

Cf. #384 (comment)
@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Jan 6, 2022
@gaborcsardi gaborcsardi mentioned this issue Jan 6, 2022
Closed
@gaborcsardi
Copy link
Member Author

It would be best to add hyperlink support to the ansi_*() functions as well.

@romainfrancois romainfrancois mentioned this issue Jan 8, 2022
Closed
4 tasks
@gaborcsardi gaborcsardi added this to the 3.2.0 milestone Jan 20, 2022
@gaborcsardi
Copy link
Member Author

I think we could think about this a bit more, so I'll skip it for now.

@gaborcsardi gaborcsardi removed this from the 3.2.0 milestone Feb 9, 2022
@hadley
Copy link
Member

hadley commented Jun 2, 2022

I think .file could also use style_hyperlink().

@gaborcsardi gaborcsardi added this to the 3.4.0 milestone Aug 23, 2022
gaborcsardi added a commit that referenced this issue Aug 26, 2022
@gaborcsardi
{.url} creates a hyperlink now
3b93ccc 
Closes #386.
gaborcsardi added a commit that referenced this issue Aug 29, 2022
@gaborcsardi
{.url} creates a hyperlink now
6426429 
Closes #386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
2 participants
@hadley @gaborcsardi