Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move type_sum to rlang and reexport #124

Closed
krlmlr opened this issue Aug 2, 2018 · 3 comments
Closed

Move type_sum to rlang and reexport #124

krlmlr opened this issue Aug 2, 2018 · 3 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Aug 2, 2018

@lionel-: Now rlang has its own version of type_sum(), perhaps the generic should be defined there? What do we need to do in rlang for this to happen? The main challenge might be testing various combinations of rlang and pillar.?
@hadley
Copy link
Member

hadley commented Aug 15, 2018

I think pillar could probably depend on a putative vec_type_sum()

@hadley
Copy link
Member

hadley commented Sep 28, 2018

Replaced by #134

@hadley hadley closed this as completed Sep 28, 2018
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @krlmlr