Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft deprecate type_sum once vctrs is on CRAN #134

Closed
hadley opened this issue Aug 20, 2018 · 3 comments · Fixed by #153
Closed

Soft deprecate type_sum once vctrs is on CRAN #134

hadley opened this issue Aug 20, 2018 · 3 comments · Fixed by #153
Labels
Milestone

Comments

@hadley
Copy link
Member

hadley commented Aug 20, 2018

And replace type_sum.default with a call to vctrs::vec_ptype_abbr()

I think this makes sense because (unless you want to control precise details of printing) then you should only need to define methods for functions in vctrs when you create a new vector class.

Technically, vec_ptype_abbr() has more limited scope than type_sum(), since it only applies to vectors, but this shouldn't be a problem for pillar/tibble since we're only concerned with things that can go in data frames.

@hadley hadley changed the title Soft deprecated type_sum once vctrs is on CRAN Soft deprecate type_sum once vctrs is on CRAN Aug 20, 2018
@krlmlr
Copy link
Member

krlmlr commented Dec 16, 2018

We could remove all specializations and only implement type_sum.default() as forwarder to vec_ptype_abbr() . Then, contact the maintainers who have implemented type_sum() in one of their packages, and remove eventually.

Is vec_ptype_abbr() stable, or do you prefer waiting a bit?

@hadley
Copy link
Member Author

hadley commented Dec 16, 2018

Yeah, I think that's right.

I don't think vec_ptype_abbr() is quite stable yet — we need to think a bit more about the family of functions that generate type names for use in different locations — r-lib/vctrs#139

@krlmlr krlmlr added the vctrs label May 3, 2019
@krlmlr krlmlr added this to the v1.4.0 milestone May 3, 2019
krlmlr added a commit that referenced this issue May 5, 2019
- `type_sum()` forwards to `vctrs::vec_ptype_abbr()` (#134). This makes sure that `list_of` columns (for values of the same type) are properly displayed (#34).
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants