-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soft deprecate type_sum once vctrs is on CRAN #134
Comments
We could remove all specializations and only implement Is |
Yeah, I think that's right. I don't think |
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary. |
And replace
type_sum.default
with a call tovctrs::vec_ptype_abbr()
I think this makes sense because (unless you want to control precise details of printing) then you should only need to define methods for functions in vctrs when you create a new vector class.
Technically,
vec_ptype_abbr()
has more limited scope thantype_sum()
, since it only applies to vectors, but this shouldn't be a problem for pillar/tibble since we're only concerned with things that can go in data frames.The text was updated successfully, but these errors were encountered: