Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-deprecation of type_sum() #154

Closed
krlmlr opened this issue May 5, 2019 · 6 comments
Closed

Soft-deprecation of type_sum() #154

krlmlr opened this issue May 5, 2019 · 6 comments
Labels
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented May 5, 2019

type_sum() now forwards to vec_ptype_abbr(), but there are concerns regarding its deprecation:

@hadley: Do we initiate soft-deprecation now? It seems safe -- it's only a message once per session, and also only for direct callers.

@krlmlr krlmlr added the vctrs label May 5, 2019
@krlmlr krlmlr added this to the v1.4.0 milestone May 5, 2019
@hadley
Copy link
Member

hadley commented May 5, 2019

I think we should avoid soft-deprecating now, if we're going to soft-deprecate to something else in the near future.

@krlmlr krlmlr removed this from the v1.4.0 milestone May 5, 2019
@krlmlr
Copy link
Member Author

krlmlr commented May 7, 2019

One thing to keep in mind: Some packages might override type_sum() to return a classed object, which affects the display of the type in a pillar. See ?pillar_type_sum.

@krlmlr
Copy link
Member Author

krlmlr commented May 9, 2019

We also should think about obj_sum() and is_vector_s3().

@krlmlr
Copy link
Member Author

krlmlr commented Dec 19, 2019

Do we move it to vctrs, along with perhaps obj_sum() and a new size_sum() (#173)?

@krlmlr krlmlr added this to the 1.5.0 milestone Jan 2, 2020
@krlmlr
Copy link
Member Author

krlmlr commented Feb 19, 2021

Let's keep the status quo for now.

@krlmlr krlmlr closed this as completed Feb 19, 2021
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants