-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soft-deprecation of type_sum() #154
Comments
I think we should avoid soft-deprecating now, if we're going to soft-deprecate to something else in the near future. |
One thing to keep in mind: Some packages might override |
We also should think about |
Do we move it to vctrs, along with perhaps |
Let's keep the status quo for now. |
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary. |
type_sum()
now forwards tovec_ptype_abbr()
, but there are concerns regarding its deprecation:Is
vec_ptype_abbr()
stable (Soft deprecate type_sum once vctrs is on CRAN #134 (comment))? Type descriptions to be shown in a word/sentence/paragraph are supposed to be new generics (Think through type labels vctrs#139 (comment)), forwarding to existingvec_ptype_abbr()
functions here.type_sum()
also works for non-vector types,vec_ptype_abbr()
does not. This isn't a huge problem, but still worth mentioning.@hadley: Do we initiate soft-deprecation now? It seems safe -- it's only a message once per session, and also only for direct callers.
The text was updated successfully, but these errors were encountered: