Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting list columns and factor columns #23

Merged
merged 10 commits into from
Jul 31, 2017
Merged

Formatting list columns and factor columns #23

merged 10 commits into from
Jul 31, 2017

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 30, 2017 •
edited
Loading

With style_subtle(), can be adapted easily. Default columns (including factors) are formatted via as.character().

Closes #3. Closes #22.

@krlmlr krlmlr requested a review from hadley July 30, 2017 09:45
@krlmlr krlmlr changed the title Formatting list columns and unknown columns Formatting list columns and factor columns Jul 30, 2017
@krlmlr
Copy link
Member Author

krlmlr commented Jul 30, 2017

List output: https://travis-ci.org/hadley/colformat/builds/259054975#L751

Factor output: https://travis-ci.org/hadley/colformat/builds/259054975#L720

@krlmlr krlmlr merged commit f7a03ca into r-lib:master Jul 31, 2017
@krlmlr krlmlr deleted the f-#3-list-cols branch July 31, 2017 06:29
@krlmlr
Copy link
Member Author

krlmlr commented Jul 31, 2017

@hadley: Please comment on the output.

@hadley
Copy link
Member

hadley commented Jul 31, 2017

Looks fine for a start. We could probably use more colour in the list col display.

@krlmlr
Copy link
Member Author

krlmlr commented Jul 31, 2017

Magenta?

@hadley
Copy link
Member

hadley commented Jul 31, 2017

I'd prefer blue or green I think

@krlmlr krlmlr mentioned this pull request Mar 1, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadley hadley Awaiting requested review from hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format for factors Format for list cols
2 participants
@krlmlr @hadley