Fix syntax highlighting on windows #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But why was it working before? Or it never was? |
|
I think it's just that more cases end up going through this path, making the problem more obvious? |
|
Edit: I think I might be wrong about this. But these bugs seem to be related on my machine. I think the issue this is intended to fix might actually be caused by r-lib/xml2#293: # using xml2 1.3.0
tmp <- tempfile()
cat("x <- 1", file = tmp)
xml2::read_html(tmp, encoding = "UTF-8")
#> {html_document}
#> <html>
#> [1] <body><p>x </p></body>
tmp <- tempfile()
cat("x = 1", file = tmp)
xml2::read_html(tmp, encoding = "UTF-8")
#> {html_document}
#> <html>
#> [1] <body><p>x = 1</p></body>Created on 2020-04-03 by the reprex package (v0.3.0) |
|
@jayhesselberth I initially thought that too, but the examples have the same problem and don't aren't processed via xml2. |
jayhesselberth
referenced
this pull request
in r-lib/xml2
Apr 4, 2020
Oh C string handling how I loathe you
Conflicts: NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1282