Set LC_ALL in translation test
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
```
══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-po.R:7:3'): translation domain correctly loaded ──────────────
withr::with_language("fr", hello()) (`actual`) not equal to "Bonjour" (`expected`).
`actual`: "Hello"
`expected`: "Bonjour"
── Failure ('test-po.R:36:3'): modifed translations are correctly reloaded ─────
withr::with_language("fr", hello()) (`actual`) not equal to "Salut" (`expected`).
`actual`: "Hello"
`expected`: "Salut"
```
Caused by these changes in glibc:
```
*********************************************************************
commit 2897b231a6b71ee17d47d3d63f1112b2641a476c
Author: Bruno Haible <bruno@clisp.org>
Date: Mon Sep 4 15:31:36 2023 +0200
intl: Treat C.UTF-8 locale like C locale (BZ# 16621)
The wiki page https://sourceware.org/glibc/wiki/Proposals/C.UTF-8
says that "Setting LC_ALL=C.UTF-8 will ignore LANGUAGE just like it
does with LC_ALL=C." This patch implements it.
* intl/dcigettext.c (guess_category_value): Treat C.<encoding> locale
like the C locale.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
*********************************************************************
via
*********************************************************************
* debian/patches/any/git-c-utf-8-language.diff: backport support from
upstream to treat C.<encoding> locale like C locale. Closes: 874160.
*********************************************************************
```
hadley
reviewed
Sep 19, 2023
| @@ -11,13 +11,21 @@ test_that("translation domain correctly loaded", { | |||
| }) | |||
|
|
|||
| test_that("modified translations are correctly reloaded", { | |||
| # Need to also specify `LC_ALL` because `LANGUAGE` is ignored when | |||
| # `LANG` is set (here via `LC_ALL`) to `C` or `C.UTF-8` | |||
There was a problem hiding this comment.
Should this go upstream into withr too?
There was a problem hiding this comment.
Here is the upstream change: r-lib/withr@687f3a3
It's only giving a warning as the caller needs to set the locale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these CRAN failures:
Kurt helpfully tracked down the failures to these changes in glibc: