Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move withr from imports to suggests #291

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Move withr from imports to suggests #291

merged 1 commit into from
Jul 31, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jul 29, 2024

So we can use pkgload with withr

@hadley
Move withr from imports to suggests
03f2bd7 
So we can use pkgload with withr
@lionel- lionel- mentioned this pull request Jul 30, 2024
Closed
@lionel-
Copy link
Member

lionel- commented Jul 30, 2024

Inlining is reasonable but there is a simpler and more general fix: r-lib/withr#265

@lionel-
Copy link
Member

lionel- commented Jul 31, 2024

Since the :: trick causes NOTEs, let's merge this in the mean time. But we'll need a solution to this issue for rlang.

@lionel- lionel- merged commit 3fe8258 into main Jul 31, 2024
13 checks passed
@lionel- lionel- deleted the withr-dep branch July 31, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @lionel-