Use doubles instead of integers (#166)

Fixes #114

NEWS.md

@@ -1,5 +1,6 @@
 # profvis (development version)
 
+* `profvis()` now uses doubles instead of integers (#114).
 * The version of jQuery bundled in profvis has been upgraded to 3.7.1 (@hedsnz, #139).
 * profvis no longer requires purrr or stringr, and no longer suggests ggplot2, devtools, knitr, or rmarkdown.
 * `profvis()` now uses elapsed time where possible (#72).

R/parse.R

@@ -28,7 +28,7 @@ parse_rprof_lines <- function(lines, expr_source = NULL) {
   label_lines <- lines[is_label]
   label_pieces <- split_in_half(label_lines, ": ", fixed = TRUE)
   labels <- data.frame(
-    label = as.integer(sub("^#File ", "", label_pieces[, 1])),
+    label = as.numeric(sub("^#File ", "", label_pieces[, 1])),
     path = label_pieces[, 2],
     stringsAsFactors = FALSE
   )
@@ -84,7 +84,7 @@ parse_rprof_lines <- function(lines, expr_source = NULL) {
       # confusing to users. For instance, profiling profvis::pause(1) can yield
       # several hundred MB due to busy waits of pause that trigger significant
       # creation of expressions that is not enterily useful to the end user.
-      memalloc <- sum(as.integer(mem[1:2])) / 1024 ^ 2
+      memalloc <- sum(as.numeric(mem[1:2])) / 1024 ^ 2
 
       # get_current_mem provides the results as either R_SmallVallocSize or R_LargeVallocSize
       # which are internal untis of allocation.
@@ -158,8 +158,8 @@ parse_rprof_lines <- function(lines, expr_source = NULL) {
 
     # Get file and line numbers
     ref_strs <- sub('^,', '', ref_strs)
-    filenum <- as.integer(sub('#.*', '', ref_strs))
-    linenum <- as.integer(sub('.*#', '', ref_strs))
+    filenum <- as.numeric(sub('#.*', '', ref_strs))
+    linenum <- as.numeric(sub('.*#', '', ref_strs))
 
     nrows <- length(labels)
     # Return what is essentially a data frame, but in list format because R is

tests/testthat/test-parse.R

@@ -14,8 +14,8 @@ test_that("parsing prof files", {
   expect_identical(p$prof$time, c(1L, 2L, 2L, 3L, 3L, 3L, 4L, 4L, 5L))
   expect_identical(p$prof$depth, c(1L, 2L, 1L, 3L, 2L, 1L, 2L, 1L, 1L))
   expect_identical(p$prof$label, c("test space", "line 2", "test", "<GC>", "line 2", "test", "<GC>", "test", ":"))
-  expect_identical(p$prof$filenum, c(1L, 1L, 1L, NA, 1L, 1L, NA, 1L, NA))
-  expect_identical(p$prof$linenum, c(1L, 2L, 1L, NA, 2L, 1L, NA, 1L, NA))
+  expect_identical(p$prof$filenum, c(1, 1, 1, NA, 1, 1, NA, 1, NA))
+  expect_identical(p$prof$linenum, c(1, 2, 1, NA, 2, 1, NA, 1, NA))
   # Memory sizes in the test-parse.prof file were chosen to create these values
   expect_identical(p$prof$memalloc, c(136, 152, 152, 168, 168, 168, 152, 152, 152))
   expect_identical(p$prof$meminc, c(0, 16, 0, 16, 0, 0, -16, 0, 0))