Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ui_*() colors based on RStudio theme #546

Closed
jennybc opened this issue Dec 11, 2018 · 3 comments
Closed

Adjust ui_*() colors based on RStudio theme #546

jennybc opened this issue Dec 11, 2018 · 3 comments
Labels
feature a feature request or enhancement tooling 🔨 Internal usethis tooling

Comments

@jennybc
Copy link
Member

jennybc commented Dec 11, 2018

The darkgrey used by ui_code() is hard to see in some RStudio contexts. Examples where RStudio is offering debugging facilities:

screen shot 2018-12-11 at 1 02 53 pm

screen shot 2018-12-11 at 12 44 43 pm

When cliapp matures or another option presents itself, take advantage to make styling adapt to a dark vs. light theme, e.g. consult rstudioapi::getThemeInfo()$dark.

https://github.com/r-lib/cliapp/blob/cbf8f1a692a44b12db508a2050c9133487ae07bc/R/simple-theme.R#L71

@hadley
Copy link
Member

hadley commented Jan 4, 2019

@jimhester do you think this should be resolved in RStudio so that the "darkgrey" colour is still readable with a dark theme?

@hadley
Copy link
Member

hadley commented Jan 23, 2019

I think this is related to rstudio/rstudio#4076

@hadley hadley added feature a feature request or enhancement tooling 🔨 Internal usethis tooling labels Jan 23, 2019
@jennybc jennybc added this to the Backlog milestone Mar 28, 2019
@jennybc jennybc removed this from the Backlog milestone Apr 10, 2019
@hadley
Copy link
Member

hadley commented Mar 14, 2020

I'm now convinced that this is really an RStudio issue, so closing in favour of rstudio/rstudio#1959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement tooling 🔨 Internal usethis tooling
Projects
None yet
Development

No branches or pull requests

2 participants